Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly pass SVGO Options #129

Merged
merged 2 commits into from Oct 11, 2023
Merged

fix: correctly pass SVGO Options #129

merged 2 commits into from Oct 11, 2023

Conversation

stramel
Copy link
Collaborator

@stramel stramel commented Jul 14, 2023

As pointed out in #100, it seems we had a bad merge conflict resolution. This properly passes the options through.

@stramel stramel added the bug Something isn't working label Jul 14, 2023
@stramel stramel added this to the v1 milestone Jul 14, 2023
@stramel stramel requested a review from natemoo-re July 14, 2023 03:17
@stramel stramel self-assigned this Jul 14, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jul 14, 2023

🦋 Changeset detected

Latest commit: 0eeacf0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro-icon Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-astroicon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2023 3:18am
astroicon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2023 3:18am

@stramel stramel changed the base branch from main to v1 July 14, 2023 03:17
@stramel stramel merged commit d445ed9 into v1 Oct 11, 2023
6 of 7 checks passed
@stramel stramel deleted the ms/pass-svgo-options branch October 11, 2023 05:35
@github-actions github-actions bot mentioned this pull request Oct 11, 2023
natemoo-re pushed a commit that referenced this pull request Dec 21, 2023
* fix: correctly pass svgo options

* Create violet-experts-travel.md

---------

Co-authored-by: Michael Stramel <michael.stramel@koyfin.com>
natemoo-re pushed a commit that referenced this pull request Dec 22, 2023
* fix: correctly pass svgo options

* Create violet-experts-travel.md

---------

Co-authored-by: Michael Stramel <michael.stramel@koyfin.com>
natemoo-re pushed a commit that referenced this pull request Dec 22, 2023
* fix: correctly pass svgo options

* Create violet-experts-travel.md

---------

Co-authored-by: Michael Stramel <michael.stramel@koyfin.com>
natemoo-re pushed a commit that referenced this pull request Dec 22, 2023
* fix: correctly pass svgo options

* Create violet-experts-travel.md

---------

Co-authored-by: Michael Stramel <michael.stramel@koyfin.com>
natemoo-re pushed a commit that referenced this pull request Dec 22, 2023
* fix: correctly pass svgo options

* Create violet-experts-travel.md

---------

Co-authored-by: Michael Stramel <michael.stramel@koyfin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant