Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix type import #141

Merged
merged 3 commits into from Dec 5, 2023
Merged

fix type import #141

merged 3 commits into from Dec 5, 2023

Conversation

liruifengv
Copy link
Contributor

Build an astro v3.0 project with astro-icon, and get a warnning:

image

Maybe it's because of the v3.0 change: https://docs.astro.build/en/guides/upgrade-to/v3/#changed-default-verbatimmodulesyntax-in-tsconfigjson-presets

@changeset-bot
Copy link

changeset-bot bot commented Sep 1, 2023

🦋 Changeset detected

Latest commit: a45f422

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
astro-icon Patch
www Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-astroicon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2023 9:43am
astroicon ❌ Failed (Inspect) Oct 4, 2023 9:43am

packages/core/lib/utils.ts Outdated Show resolved Hide resolved
@FDiskas
Copy link
Contributor

FDiskas commented Oct 3, 2023

Related issue #140

Co-authored-by: Vytenis <projektas@gmail.com>
@fflaten
Copy link

fflaten commented Nov 10, 2023

Hi @natemoo-re. Any chance we could get a patch release with this? Unless v1 is really close. 🙂

@natemoo-re natemoo-re linked an issue Dec 5, 2023 that may be closed by this pull request
Copy link
Owner

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

@natemoo-re natemoo-re merged commit 832ac05 into natemoo-re:main Dec 5, 2023
5 of 6 checks passed
@github-actions github-actions bot mentioned this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting this warning while building astro 3.0.4
5 participants