Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1] Convert core package to TS #96

Merged
merged 3 commits into from Jun 6, 2023
Merged

[v1] Convert core package to TS #96

merged 3 commits into from Jun 6, 2023

Conversation

stramel
Copy link
Collaborator

@stramel stramel commented May 23, 2023

This converts the core package to TypeScript. This brings us inline with existing official integrations and provides type-safety.

@stramel stramel requested a review from natemoo-re May 23, 2023 15:15
@stramel stramel self-assigned this May 23, 2023
@changeset-bot
Copy link

changeset-bot bot commented May 23, 2023

⚠️ No Changeset found

Latest commit: 9e55dce

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented May 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-astroicon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2023 1:34am
astroicon ❌ Failed (Inspect) Jun 6, 2023 1:34am

@stramel stramel changed the title Convert core package to TS [v1] Convert core package to TS May 25, 2023
Copy link
Owner

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@natemoo-re natemoo-re merged commit 8a33345 into v1 Jun 6, 2023
3 of 4 checks passed
@natemoo-re natemoo-re deleted the ms/convert-to-typescript branch June 6, 2023 01:35
natemoo-re added a commit that referenced this pull request Jun 6, 2023
* chore: convert core package to typescript

* update lockfile

* chore(lint): Prettier fix

---------

Co-authored-by: Michael Stramel <michael.stramel@koyfin.com>
Co-authored-by: Nate Moore <nate@astro.build>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
natemoo-re added a commit that referenced this pull request Dec 21, 2023
* chore: convert core package to typescript

* update lockfile

* chore(lint): Prettier fix

---------

Co-authored-by: Michael Stramel <michael.stramel@koyfin.com>
Co-authored-by: Nate Moore <nate@astro.build>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
natemoo-re added a commit that referenced this pull request Dec 22, 2023
* chore: convert core package to typescript

* update lockfile

* chore(lint): Prettier fix

---------

Co-authored-by: Michael Stramel <michael.stramel@koyfin.com>
Co-authored-by: Nate Moore <nate@astro.build>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
natemoo-re added a commit that referenced this pull request Dec 22, 2023
* chore: convert core package to typescript

* update lockfile

* chore(lint): Prettier fix

---------

Co-authored-by: Michael Stramel <michael.stramel@koyfin.com>
Co-authored-by: Nate Moore <nate@astro.build>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
natemoo-re added a commit that referenced this pull request Dec 22, 2023
* chore: convert core package to typescript

* update lockfile

* chore(lint): Prettier fix

---------

Co-authored-by: Michael Stramel <michael.stramel@koyfin.com>
Co-authored-by: Nate Moore <nate@astro.build>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
natemoo-re added a commit that referenced this pull request Dec 22, 2023
* chore: convert core package to typescript

* update lockfile

* chore(lint): Prettier fix

---------

Co-authored-by: Michael Stramel <michael.stramel@koyfin.com>
Co-authored-by: Nate Moore <nate@astro.build>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants