Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add utils and reuse functions in torch and flax pipelines #157

Merged
merged 7 commits into from
Feb 6, 2023

Conversation

charlielito
Copy link
Contributor

@charlielito charlielito commented Jan 28, 2023

Added utils.py to reuse some functions in both pipelines (flax and torch)

@charlielito
Copy link
Contributor Author

charlielito commented Jan 29, 2023

Just added the missing features for flax:

  • Implemented negative_prompt in the flax pipeline
  • Implemented image_generation for Flax to be used in the Gradio App

@nateraw
Copy link
Owner

nateraw commented Jan 31, 2023

Thanks again for a great contribution!! Read through the code in depth last night. Looks good I think - I'll get this approved and merged this week sometime...got a few projects I'm juggling rn.

This PR really reminds me I should close out #54 so we dont run into diffs with style changes applied, makes PR changes a bit harder to read. Not your fault, my fault.


Unrelated: By the way @charlielito - do you have a Twitter? I'd like to tweet about the TPU release + tag you if you have one.

@charlielito
Copy link
Contributor Author

This PR really reminds me I should close out #54 so we dont run into diffs with style changes applied, makes PR changes a bit harder to read. Not your fault, my fault.

Yeah, I know :( I tried to configure black (number of chars per line) to not change that much the already existing code.

Unrelated: By the way @charlielito - do you have a Twitter? I'd like to tweet about the TPU release + tag you if you have one.

For sure! my user is @charlielito42

Copy link
Owner

@nateraw nateraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nateraw nateraw merged commit 07b1869 into nateraw:main Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants