Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resume support #42

Merged
merged 8 commits into from
Sep 20, 2022
Merged

Resume support #42

merged 8 commits into from
Sep 20, 2022

Conversation

nateraw
Copy link
Owner

@nateraw nateraw commented Sep 20, 2022

Continuation of #35 by @codefaux. Separated to new branch so I could safely fix history issues without damaging original PR.

I moved resume to be a kwarg instead of separate function. Here's how I'm using it:

Given an unfinished run at dreams/20220912-100023, I run this:

walk(
    output_dir='dreams',
    name='20220912-100023',
    resume=True
)

@nateraw nateraw mentioned this pull request Sep 20, 2022
@nateraw
Copy link
Owner Author

nateraw commented Sep 20, 2022

Thanks again for your work here @codefaux !! lmk if I missed anything. Merging for now.

@nateraw nateraw merged commit 4b59f62 into main Sep 20, 2022
@nateraw nateraw deleted the resume_support_restructure branch September 20, 2022 22:38
@codefaux
Copy link
Contributor

Hey thanks, glad to see it used. It's been a very useful feature, and the only reason I'm willing to tackle things like my 10,000 frame "daydream" videos project. I'm excited to see what else it enables others to consider creating. Looks like it should even resume my current run without issue, which is always a bonus. Good working with you.

@nateraw
Copy link
Owner Author

nateraw commented Sep 21, 2022

If any other feature requests come up, feel free to drop them in the issues section 😄 . Was great workin with you on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants