added param typing to walk function and updated the walk function to take in num_steps as a list #52
Conversation
…ake in num_steps as a list
| resume=False, | ||
| batch_size=1, | ||
| frame_filename_ext='.png', | ||
| prompts:list = ["blueberry spaghetti", "strawberry spaghetti"], |
There was a problem hiding this comment.
Thanks for the type hints here! But can we do List[str]/List[int] for list types? Using from typing import List..., etc.
| frame_filename_ext='.png', | ||
| prompts:list = ["blueberry spaghetti", "strawberry spaghetti"], | ||
| seeds:list = [42, 123], | ||
| num_steps:list=[5], |
There was a problem hiding this comment.
Leave default here as int. type it as Union[int, List[int]].
| ): | ||
| """Generate video frames/a video given a list of prompts and seeds. | ||
|
|
||
| Args: | ||
| prompts (List[str], optional): List of . Defaults to ["blueberry spaghetti", "strawberry spaghetti"]. | ||
| seeds (List[int], optional): List of random seeds corresponding to given prompts. | ||
| num_steps (int, optional): Number of steps to walk. Increase this value to 60-200 for good results. Defaults to 5. | ||
| num_steps (list, optional): list of number of steps to walk during each interpolation step. The size of num_steps should be len(prompts)-1. Increase this value to 60-200 for good results. Defaults to [5]. |
There was a problem hiding this comment.
| num_steps (list, optional): list of number of steps to walk during each interpolation step. The size of num_steps should be len(prompts)-1. Increase this value to 60-200 for good results. Defaults to [5]. | |
| num_steps (Union[int, List[int]], optional): Number of steps to walk during each interpolation step. If int is provided, use same number of steps between each prompt. If a list is provided, the size of `num_steps` should be `len(prompts) - 1`. Increase values to 60-200 for good results. Defaults to 5. |
There was a problem hiding this comment.
formatting might need to be updated here.
| resume=False, | ||
| batch_size=1, | ||
| frame_filename_ext='.png', | ||
| prompts:List[str] = ["blueberry spaghetti", "strawberry spaghetti"], |
There was a problem hiding this comment.
| prompts:List[str] = ["blueberry spaghetti", "strawberry spaghetti"], | |
| prompts: List[str] = ["blueberry spaghetti", "strawberry spaghetti"], |
If you can, please apply this spacing to all args 😄
There was a problem hiding this comment.
Or if you don't want to go back and forth on my style nit-picks I can do it myself in separate PR
There was a problem hiding this comment.
sure! no, I agree with those changes. thank you for bringing them up. it would be good to add a Makefile to run style checks and linters.
|
|
||
| frame_index = 0 | ||
| for prompt, seed in zip(prompts, seeds): | ||
| total_frame_count = sum(num_steps) |
There was a problem hiding this comment.
thank you.
|
@danielpatrickhug ready for review again? |
|
@nateraw Hey, yes, it should be good to go. please let me know if you have any other suggestions :) |
|
cool - apologies if it takes me a few days to get this merged...will have to resolve conflict + give it a test drive and I have a few other things I'm juggling. From first glance it looks like its ready to go though :) |
Hello, @nateraw
issue reference: #41