Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ftplugin/yang.vim: Always add - to iskeyword #12

Merged
merged 1 commit into from Sep 23, 2020

Conversation

cdleonard
Copy link
Contributor

This makes it easy to navigate yang files using # and *

Signed-off-by: Leonard Crestez cdleonard@gmail.com

This makes it easy to navigate yang files using # and *

Signed-off-by: Leonard Crestez <cdleonard@gmail.com>
@nathanalderson
Copy link
Owner

Seems reasonable to me. @dimbleby put this code in, though. Maybe he can offer a review/explanation?

@dimbleby
Copy link
Contributor

I think the history is this commit where I used syntax iskeyword and then learned that old versions of Vim didn't support it. So my intention was to fall back to plain iskeyword in that case.

The only downside I can see to this change is that this setting will also apply to text in comments and strings, which isn't necessarily what you want, and much of the YANG that I see is mostly text description. But most of the words in those descriptions are unhyphenated!

In short: seems fine to me.

Copy link
Owner

@nathanalderson nathanalderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, then!

@nathanalderson nathanalderson merged commit 0edaeb6 into nathanalderson:master Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants