Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Iterator metadata collection #12

Merged
merged 3 commits into from
Apr 3, 2023
Merged

Conversation

nathanbabcock
Copy link
Owner

Closes #10

  • Rewrite metadata collection to avoid an inner loop inside the constructor
    • On certain errors execution could block inside this inner loop, never yielding items to the Iterator
  • Collect metadata into a single struct
  • Add collect_metadata method to advance iterator past metadata section and return the finalized metadata
  • Recognize audio streams and other stream types, though no parsing of their contents yet

@nathanbabcock nathanbabcock merged commit b8c1a53 into main Apr 3, 2023
@nathanbabcock nathanbabcock deleted the fix/iter-blocking branch April 3, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FfmpegIterator::new() incorrectly blocks until the FFmpeg process ends (!)
1 participant