Feature: Add 'visible' assertion for testing visibility !== hidden or collapse #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanboktae
approved these changes
Mar 13, 2018
There was a problem hiding this comment.
So when I originally started this based on chai-jquery, I very much did not want visibility to be here because it used jQuery's :visibile custom psudeoselector which was non-standard and very complex. I wanted to force people to write a different assertion. It's been 3 years now since then, so perhaps this is fine to add now. The implementation is sound and straight-forward, mapping directly and only to the CSS visibility selector.
| }) | ||
|
|
||
| it('passes when visible (any visibility value but hidden or collapse)', function() { | ||
| div.should.be.visible |
There was a problem hiding this comment.
a div with visibility: visible may be nice, but this is probably fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This PR proposes/adds a new assertion to complement the
.displayedassertion, which tests for the CSS propertyvisibilitybeing unequal tohiddenorcollapse.I'm not really sure what to say about it other than that. 馃槀 I've been using
chai-domin a project of mine, and I was just surprised to see that there was no analog of.displayedto test whether elements were hidden using thevisibilityproperty. It's a pretty straightforward thing to add, since it follows pretty much the same "format" as.displayed, as far as code is concerned, so I figured I'd add it real quick and submit a PR.Cheers!