Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup ssl-protocol=any by default and add ssl-errors option #179

Closed
wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 1, 2015

Add ignore ssl errors and set ssl-protocol=any by default

@nathanboktae
Copy link
Owner

Since 1.9.8 the default SSL protocol is now tlsv1 not sslv3. This is more secure than any. See ariya/phantomjs#12655.

I like the other fix if you back out any.

@ghost
Copy link
Author

ghost commented Apr 1, 2015

ok, I've updated PR.
Look, please.

@nathanboktae
Copy link
Owner

Did you forget to push? Still only 1 commit.

@ghost
Copy link
Author

ghost commented Apr 1, 2015

No, I've updated current commit :)

@nathanboktae
Copy link
Owner

FYI if you ever need to provide additional phantom args, phantomjs lib/mocha-phantomjs.coffee <page> <reporter> <config> is something we support (semver wise)

@ghost
Copy link
Author

ghost commented Aug 13, 2015

Up. Now ignore-ssl-errors is boolean.

@nathanboktae
Copy link
Owner

mocha-phantomjs 4.0.0 now passes all unknown options along to phantomjs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant