fix #65: Added message back to user when the path given does not exist #95
Conversation
| if (!exists(program.path)) { | ||
| print("PhantomJS does not exist at '" + program.path + "'\n"); | ||
| process.exit(1) | ||
| } |
There was a problem hiding this comment.
Wont this keep the other ways of finding the phantomjs bin below this?
https://github.com/metaskills/mocha-phantomjs/blob/master/bin/mocha-phantomjs#L96-L114
There was a problem hiding this comment.
In my opinion, it's about dependancy.
If a user depends on a different version of PhantomJS then what is installed in the bin, then that user will be expecting that specific path to be used. The user probably has a specific reason for using the path argument as it is optional.
For example, what happens if the user misspells the path and the bin version is used. It could fail and the time the user spends debugging could result in time lost. By just failing the program and telling the user that the path is incorrect, they will get immediate feedback. Resulting is no time lost for misspelling the path to PhantomJS.
|
Hmmm, I forgot that w now have a --path argument via ticket #64. When I think about it, that is what I think this ticket exposes more work once we took on that responsibility, sigh. Anyways, maybe we should just warn if the path argument is not found and continue searching. Then if no phantomsjs is found, we exit with an error. |
…he warning to be in the stdout
|
Changing the symlink to the bin would be annoying if you had two projects that use different versions of PhantomJS. On the the other hand, failing the app if the path argument is wrong could be too dramatic. I think a warning would be fine. I updated the code and tests to just send a warning to the stderr. |
fix #65: Added message back to user when the path given does not exist
No description provided.