Support FAT12 sectors larger than 512 bytes #30
Conversation
|
It seems the default tests from pyfilesystem2 include ~10MB of data, but the default FS size in test_PyFatFS.py is 4MB for FAT12. Added another table entry to allow up to 16MB for FAT12 and updated the test to allocate 15MB for FAT12. |
pyfatfs/PyFat.py
Outdated
| (4084, 1), # disks up to 2 MB, .5k cluster | ||
| (8168, 2), # disks up to 4 MB, 1k cluster | ||
| (16336, 4), # disks up to 8 MB, 2k cluster | ||
| (32672, 8) # disks up to 16 MB, 4k cluster |
There was a problem hiding this comment.
Awesome, thank you very much for your contribution as well as fixing the tests!
Do you think it would also make sense to add support for larger combinations such as:
- 65344/16: 32MB, 8k cluster
- 130688/32: 64MB/32k cluster
- 261376/64: 128MB/64k cluster
Maybe even the non-standard 522752/128 (256MB, 64k cluster)?
There was a problem hiding this comment.
Sure, I will add those. Originally I stopped the table at 4MB based on this comment from fatgen103.doc: "If your media is larger than 4 MB, do not bother with FAT12." But it should be fine to support the larger sizes.
In the mkfs function, the FAT12 cluster size of 64 sectors limits FAT12 implementations to 512-byte sectors only.
This change introduces a new table while maintaining the 4084-cluster limit for FAT12 prescribed by fatgen103.