Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npx installs "undefined" npm package #45

Closed
JoshWhite opened this issue Jan 10, 2019 · 2 comments
Closed

npx installs "undefined" npm package #45

JoshWhite opened this issue Jan 10, 2019 · 2 comments

Comments

@JoshWhite
Copy link

JoshWhite commented Jan 10, 2019

Running install-peerdeps (at least via npx on Windows) causes https://www.npmjs.com/package/undefined to be installed as a dependency.

Repro steps

npm init
npx install-peerdeps --dev eslint-config-airbnb

Output:

C:\experiments\install-peerdeps-bug>npx install-peerdeps --dev eslint-config-airbnb
npx: installed 82 in 27.915s
install-peerdeps v1.10.1
Installing peerdeps for eslint-config-airbnb@latest.
npm install eslint-config-airbnb@17.1.0 eslint@5.3.0 eslint-plugin-import@^2.14.0 eslint-plugin-jsx-a11y@^6.1.1 eslint-plugin-react@^7.11.0 --save-dev

npm WARN deprecated undefined@0.1.0: this package has been deprecated
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN install-peerdeps-bug@1.0.0 No description
npm WARN install-peerdeps-bug@1.0.0 No repository field.

+ eslint-config-airbnb@17.1.0
+ undefined@0.1.0
+ eslint-plugin-import@2.14.0
+ eslint-plugin-react@7.11.0
+ eslint-plugin-jsx-a11y@6.1.1
+ eslint@5.3.0
added 194 packages from 106 contributors in 62.956s
SUCCESS eslint-config-airbnb
  and its peerDeps were installed successfully.

C:\experiments\install-peerdeps-bug>

Environment

Windows 10
npm v6.4.1
node v10.13.0

Further info

It doesn't do this, when you add the --extraArgs flag.

@nathanhleung
Copy link
Owner

Thanks for catching this! Will fix ASAP

@nathanhleung
Copy link
Owner

nathanhleung commented Jan 10, 2019

Also, I think you're right on with why this is happening, so kudos!

nathanhleung added a commit that referenced this issue Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants