Add option to pass Auth header #23
Conversation
| @@ -6,7 +6,7 @@ | |||
| "scripts": { | |||
| "test": "jest", | |||
| "lint": "eslint src/ --fix", | |||
| "build": "babel src --out-dir lib --ignore **/*.test.js", | |||
| "build": "babel src --out-dir lib --ignore *.test.js", | |||
There was a problem hiding this comment.
The previous pattern was not matching because all of the test files are at the root of the src folder. Now the tests are not being built into lib 💃
| packageName | ||
| } and its peerDeps were installed successfully.`; | ||
| let successMessage = `${ | ||
| C.successText |
There was a problem hiding this comment.
I think the linter can't make up it's mind regarding where it wants to do those line breaks...
| `This command would have been run to install ${packageName}@${ | ||
| version | ||
| }:` | ||
| `This command would have been run to install ${packageName}@${version}:` |
There was a problem hiding this comment.
Again, this is something that was picked up by the autolinting and changed.
|
I also noticed that the test suite is failing, but it also seems to be failing on the same test in master and unrelated to the new code. |
|
Thank you for the pull and the comprehensive review comments. Also appreciate that you updated the README. Will merge and release today. |
|
Also, with regard to the tests, you're right - still working on them. Thanks for checking though. |
I was unable to add a private package because there was not a way to pass the auth token to the request, so I updated the cli to take an auth option and then updated the request function to send an authorization header.
There are also some strange formatting changes from the linter... it's breaking the lines in different places.