Add method for playing a sound with a given pitch #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanhoad
requested changes
Oct 1, 2023
Comment on lines
54
to
59
| func play_sound(resource: AudioStream, pitch: float = 1.0, override_bus: String = "") -> AudioStreamPlayer: | ||
| return sound_effects.play(resource, pitch, override_bus) | ||
|
|
||
|
|
||
| func play_ui_sound(resource: AudioStream, override_bus: String = "") -> AudioStreamPlayer: | ||
| return ui_sound_effects.play(resource, override_bus) | ||
| func play_ui_sound(resource: AudioStream, pitch: float = 1.0, override_bus: String = "") -> AudioStreamPlayer: | ||
| return ui_sound_effects.play(resource, pitch, override_bus) |
There was a problem hiding this comment.
This will be changing the public interface for these methods - they should be added as new methods (something like play_sound_with_pitch(..)).
nathanhoad
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
sound_effects.play(),SoundManager.play_sound(), andSoundManager.play_ui_sound()functions to accept a pitch parameter.Added an example of a random pitch sound effect to
Example.tscn.