Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodehun not compatible with node 0.12 and iojs #19

Closed
rexxars opened this issue Feb 17, 2015 · 6 comments
Closed

Nodehun not compatible with node 0.12 and iojs #19

rexxars opened this issue Feb 17, 2015 · 6 comments

Comments

@rexxars
Copy link
Contributor

rexxars commented Feb 17, 2015

I can't seem to build nodehun on node 0.12 and iojs.
I'm guessing this is because of an updated V8?

@nathanjsweet
Copy link
Collaborator

Yeah, I'll be getting to this soon (hopefully this weekend or next).

@nathanjsweet
Copy link
Collaborator

this is done

@rexxars
Copy link
Contributor Author

rexxars commented Feb 22, 2015

Cool. I don't mean to offend in any way, but have you considered using https://github.com/rvagg/nan for abstracting the differences between versions?

Right now it's hard to depend on this project because basically we will be forced to follow the same scheme as you, requiring a given version of node for a given version of our modules.

@nathanjsweet nathanjsweet reopened this Feb 22, 2015
@nathanjsweet
Copy link
Collaborator

This is a note to myself:
https://github.com/rvagg/nan/blob/master/nan.h
I'm going to use node_version.h to build the two different versions based on using ifdef pragmas in the compiler.

@nathanjsweet
Copy link
Collaborator

I'm not using NAN, but users shouldn't have to worry about versions anymore

@rexxars
Copy link
Contributor Author

rexxars commented Feb 25, 2015

Thanks Nathan, that's great! Thank you for your hard work 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants