Adds Floating functionality to mjolnir.tiling #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the user to specify if a window should or should not be included in the tiling calculations and layouts.
| @@ -27,15 +44,7 @@ function tiling.cycle(direction) | |||
| local currentindex = fnutils.indexof(windows, win) | |||
| local layout = space.layout | |||
| if not currentindex then return end | |||
| local nextindex = currentindex + direction | |||
There was a problem hiding this comment.
A lot of this could've been simplified by using modulo. Needed to add 1 because Lua arrays start at 1 not 0.
|
Looks good, thanks for this!! |
nathankot
added a commit
that referenced
this pull request
Nov 17, 2014
Adds Floating functionality to mjolnir.tiling
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the user to specify if a window should or should not
be included in the tiling calculations and layouts.
Implements feature request #4
Here's a demo
Please review @nathankot