Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for m2e plugin #56

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix for m2e plugin #56

wants to merge 2 commits into from

Conversation

msolujic
Copy link

Fixed problem with eclipse maven problem described here
http://wiki.eclipse.org/M2E_plugin_execution_not_covered

@miguno
Copy link
Contributor

miguno commented Mar 25, 2014

Milos,

thanks for your pull request. Please note that we will not merge this pull request for an organization reason: The storm-starter project was merged into and now lives under the core Apache Storm project. As such storm-starter now resides in a sub-directory examples/storm-starter at https://github.com/apache/incubator-storm/tree/master/examples/storm-starter. (Also: The fact that you and others may have not been aware of this recent move made us update the storm-starter README to highlight this move and point people to the new home of storm-starter.)

As part of this merge the build setup of storm-starter was consolidated with the build setup of the core Storm project. The effect is that storm-starter is now exclusively built with Maven (and not with Leiningen anymore), and as part of that change the m2-pom.xml file was removed and replaced by a (modified) pom.xml.

Now back to your pull request because it should not have been sent in vain: Maybe storm-starter's new pom.xml already covers the problem addressed by your pull request. If you don't mind would you take a look at the new setup at https://github.com/apache/incubator-storm/blob/master/examples/storm-starter and verify whether your problem still exists? If yes, feel free to send a pull request based on that code to the core Storm project.

Again, many thanks!

@msolujic
Copy link
Author

msolujic commented Apr 8, 2014

Hey Mike,
sorry for late response.

Seams like I went with my small patch at very bad time, same day you moved project under apache root project.

There is still same problem with m2e plugin, which is now not resolved with same trick, probably because now starter is no independent maven project. I'll try to resolve it and will do PR if successful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants