Fix issue #403 #428
Merged
Fix issue #403 #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @herberteuler and @nathanmarz . I verified that cached sockets map does not remove closed zmq socket by logging. But I can not explain why the closed zmq socket will be used since the :cached-task->node+port map is updated correctlly. |
|
@xiaokang You may need to check if the old node+port that the dead worker used has been reassigned to run a new worker. If this happens, the same old node+port will still be needed and used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Nathan, I believe this patch fixes issue #403.
You are right, it was not race condition, but rather some already closed sockets might be left in the new cached sockets map, due to the wrong invocation to dissoc.