Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where is the ECSRole used #9

Open
hoegertn opened this issue Oct 9, 2018 · 2 comments
Open

Where is the ECSRole used #9

hoegertn opened this issue Oct 9, 2018 · 2 comments

Comments

@hoegertn
Copy link

hoegertn commented Oct 9, 2018

I do not see any usage of ECSRole. Is this really needed?

@flowirtz
Copy link

I agree, I also don't see any usage of ECSRole.

@rslangham
Copy link

I am thinking that the ECSRole was intended for the TaskDefinition TaskRoleArn. The option is sorta there from the top level stack "Role" parameter, related to the HasCustomRole condition. It may be nice for the example to assign the ECSRole to the task definition instead of deleting the role. Though, think there is enough sample cloudformation here that it could be understood what to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants