This repository has been archived by the owner on Aug 5, 2021. It is now read-only.
Remove potentially unused ECSRole from fargate template #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call me stupid, but I don't see where the
ECSRoleis used. 馃檲I think it could be used with the
PrismaService(AWS::ECS::Service), as described here, but this states:We are indeed using
awsvpcnetwork mode.(Sorry for the Terraform link, I am not using Cloudformation but this should still apply.)
See nathanpeck/aws-cloudformation-fargate#9
PS I'm rewriting the two cloudformation files from the guide in Terraform atm, would you be interested in that or do you not really care?