Fix inconsistency with libc attribute decoration #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decorating the `Event` structure with the "packed" attribute, regardless of the platform, is incorrect since libc decorates the`libc::epoll_event` only for x86_64 platforms. As a consequence, on other architectures the size of the `Event` structure is different than that of the `libc::epoll_event` which is a trigger for inconsistent behavior. Signed-off-by: Diana Popa <dpopa@amazon.com>
|
Oh dip, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decorating the
Eventstructure with the "packed" attribute,regardless of the platform, is incorrect since libc decorates thelibc::epoll_eventonly for x86_64 platforms. As a consequence, on other architectures the size of theEventstructure is different than that of thelibc::epoll_eventwhich is a trigger for inconsistent behavior.See
__EPOLL_PACKEDinside glibc source which is defined to__attribute__ ((__packed__))only for x86_64 platforms.