Fix layout issues on iPad pagesheets #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kaspik
requested changes
May 23, 2023
Kaspik
changed the title
|
I pushed some tweaks to the master branche. Can you see it? The reason for starting the animation a second time inside dispatchqueue is because on iPad in portrait when the keyboard slides in the pagesheet will move up a little too. So you need to wait a cycle to get te correct compensation value or else you'll still have a gap. |
Kaspik
approved these changes
May 23, 2023
|
Add info to the Changelog please. :) |
- code optimizations
|
I added a line to the changelog. I also did some code optimizations to prevent unnecessary calling of Oh and turned out I made a stupid mistake in the process which I fixed. Sorry for the confusion. |
Kaspik
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This fixes layout (gap) issues when keyboard appears on iPad when VC is presented as pagesheet of formsheet.
Does this close any currently open issues?
Closes #238
Any relevant logs, error output, etc?
none
Any other comments?
The fixes are a bit hacky but it's the only way I could find that works.
Where has this been tested?
Devices/Simulators:
iPad with and without home button, landscape and portrait (important). Also tested on various iPhones to make sure it kept working fine there too.
iOS Version:
14/15/16
Swift Version:
the one used by Xcode 14.3
InputBarAccessoryView Version:
6.2.0