Optional custom 'passToStore' code #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
Great feature, tnx @joshuamorris3 |
|
@weglov are you publishing to npm this update? |
|
@intech a new version (2.0.8) was published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Via the
passToStoreHandlerconfiguration option, you can provide a replacement or additional logic for thepassToStorecode insrc/Observer.js.The function you provide will be passed the following arguments:
function (eventName, event). This allows you to optionally do some basic preprocessing before handing the event over to the original handler.The original passToStore code is used if no
passToStoreHandleris configured.I've added new documentation describing this in more detail in README.md.
The one addition I'm not sure about is giving the custom
passToStoreHandlerfunction thethisof thesrc/Observer.jsby passing it in as an argument, or doing a.bind(this). Let me know if you think is something that should be added.