-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Object.seal will throw an error in IE11 #75
Comments
I have the same: [Vue warn]: Error in created hook: "TypeError: Object.seal: argument is not an Object" "vue": "^2.5.17", |
放弃这个插件吧,ie11g等不支持Proxy的逻辑作者没有实现好,无法使用 |
This is not a solution and this bug should not be marked as "fixed" this is a work around/hack Only mount the plugin if modern browser In your main.js file:
|
@larsmars this guy made it work without using Proxy object. Tested it and it works properly. |
What did he do? That package ref. to this repo. |
I've fixed the same error with @babel/polyfill |
I think it's because the |
Hi, I see strange option `sockets` parameter which can be undefined if user didn't define it in `Vue` options. If I understand as right it may be bug. It can be related with this opened issue: nathantsoi#75 And the [Object.seal should get the object type](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/seal#Non-object_coercion). If it will be not object ES5 code will throw error. I didn't test it but i saw code and think that's should be patched.
Now in build (https://raw.githubusercontent.com/nathantsoi/vue-native-websocket/master/dist/build.js) there is
Object.seal(this.$options.sockets)
usingIE11 doesn't know what it is & will throw error. I think need to include polyfill for Object.seal or mention about it in readme
The text was updated successfully, but these errors were encountered: