Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lossless conversion bit depth issues #616

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Conversation

disconnect78
Copy link
Contributor

When converting to a lossless codec, there are two issues relating to the bit depth:

This can be fixed by refactoring lossless conversion to always pass an aformat filter, containing sampling rate and/or bit depth (whereas previously only the sampling rate was in an aformat filter). This allows us to pass a list of bit depths; so not only can we specify both planar and non-planar formats (so ffmpeg can simply pick whichever applies to the specified codec), but if a list of bit depths is specified then ffmpeg won't use a bit depth higher than that of the source file.

@nathom
Copy link
Owner

nathom commented Feb 7, 2024

Looks good. Thanks!

@nathom nathom merged commit 4353c84 into nathom:dev Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants