-
-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable aiohttp client timeout #689
Conversation
Possibly for #672? The error at the end of debug log is similar |
Important thing to note: This needs further testing. I've successfully downloaded files that took over 5 minutes (default aiohttp client timeout). However, when testing with some artist, after some time, it still crashed with the same error message |
Those issues are different I think, and the The reason should be checked in the previous messages. The #580 user haven't explained the details of his problem, I'd say he pressed Ctrl+C because of #645, #689, the error is So they probably should be treated separately, and require different solutions. |
Could you share the debug log that you get when it crashes? |
Another example, as I've run the command from #580, it terminated itself with another error
Which I don't know where comes from, as "host machine" is my PC as I understand, Will check with full debug and with the full stack trace, though don't know how to show it yet ) |
btw, it would be more useful to have a test reproducing/simulating the problem |
As @mortalis13 said, this is caused by uncaught exceptions, which terminates the program without resolving the coroutines in the event loop. It's not an error, just a message to notify the dev in case a coroutine was created but never resolved. Changing the client timeout won't change anything. The message is just an indicator that there is another error. |
A fix for
RuntimeWarning: coroutine 'Artist._download_async.<locals>._rip' was never awaited
error messagePotentially fixes: #555, #580, #645