Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deezer alternative track #700

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

slanglade
Copy link

Track IDs on deezer are updated quite frequently, because of some obscure track duplication. And the old version is not playable anymore. When you listen to a playlist, it contains the old identifiers, but you don't notice because the deezer interface manages to retrieve the new track version anyway.

But when streamrip retrieves the track list from a playlist, it ends up with the wrong identifiers.

This PR covers the modifications made to get around the problem (#638), in the following order of preference:

  • use the “Alternative” field sometimes provided by deezer, when a new track is correctly linked from the old version.
  • use a search on album title, artist name and track name.

During this process, log messages are sent to the console (WARNING if alternative found, ERROR if no alternative is found).

@nathom
Copy link
Owner

nathom commented Jun 10, 2024

Thanks. Can you make sure the ruff checks pass?

@slanglade
Copy link
Author

Ah, nice, didn't notice the ruff tests yelling at me 😄. Ok, done

@slanglade
Copy link
Author

slanglade commented Jun 10, 2024

I don't understand the meaning of ruff's test result, which is rather cryptic. I understand that it complains about file formatting, but i don't know what is expected. Can you give me a hint ?

@nathom
Copy link
Owner

nathom commented Jun 10, 2024

Run ruff format

@nathom
Copy link
Owner

nathom commented Jun 11, 2024

Ok I fixed formatting and some minor issues. Can you verify that it still works with the broken track URL? Also, can you please provide the URL that doesn't work here for the record?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants