Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core - Rework style / theme #174

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

EmreTech
Copy link
Contributor

This one tackles issue #132, where the current Style/Theme system is reworked.

Here's what's done so far:

  • Reworked the concept of Style and Theme, where Theme stores both colors/metrics
  • Changed from using a programmatically way to define values to an XML way
  • Made Style wrapper for backward compatibility

@JSH32
Copy link

JSH32 commented Apr 7, 2022

Ok I know this is a bad place to contact but is your fork of borealis stable enough to use in a normal app? I'm noticing problems with borealis currently like the fact that it was in a rewrite when I cloned it over. Hints don't show and all that. I assume you fixed that based on the issue history of this repo?

@EmreTech
Copy link
Contributor Author

EmreTech commented Apr 7, 2022

It might be. You'll have to merge the commits from my libnx branch fix and my other feature branches in order to use the features I implemented

@JSH32
Copy link

JSH32 commented Apr 8, 2022

Does your fork have any way to make a list of various objects, maybe like a game list? Or like the old implemented full width buttons in SimpleSaveManager for example?

@EmreTech
Copy link
Contributor Author

EmreTech commented Apr 8, 2022

You should be able to make that with the tools you're provided with, but I don't think that's built into the yoga rewrite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants