Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update homepage header #706

Merged
merged 7 commits into from May 19, 2023
Merged

Update homepage header #706

merged 7 commits into from May 19, 2023

Conversation

Donna-H
Copy link
Member

@Donna-H Donna-H commented May 18, 2023

Changes in this PR:

Update homepage header -revisiting the use of the TNA logo on the site- use the narrow version of the logo- users to access the page content more quickly and so this work will reduce the scrolling required.

Trello card / Rollbar error (etc)

https://trello.com/c/XSEVm87x/912-pui-homepage-header

Screenshots of UI changes:

Before

old-desktop
old-mobile

After

new-desktop
new-mobile

  • Requires env variable(s) to be updated

@codecov-commenter
Copy link

Codecov Report

Merging #706 (8f4f899) into main (82b2bc2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #706   +/-   ##
=======================================
  Coverage   92.17%   92.17%           
=======================================
  Files          25       25           
  Lines        1086     1086           
  Branches       55       55           
=======================================
  Hits         1001     1001           
  Misses         71       71           
  Partials       14       14           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@jacksonj04 jacksonj04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of tweaks to make, but this is looking so much cleaner already. There's so much space! Readers will love it, even if they don't notice it.

  • The typography purist in me is screaming at the fact that "Find Case Law" and the TNA logo are top-aligned and not baseline-aligned.
  • This PR says it's about the homepage, but we're ditching the logo image which is used everywhere, so all of the judgment pages look weird
  • The mobile breakpoint is set too wide, so it's possible to make the viewport narrow enough it clips the logo before it breaks to mobile
  • The flexbox isn't centring properly, so if your viewport is wider than the maximum breakpoint then it hangs over the left margin and leaves a load of space to the right.

It might be easier to consider slicing this into two distinct bits; "Find case law" and "Delivered by..." in one include, and then the service blurb in another. That way we can also repurpose the top include on judgment pages, pop the breadcrumbs back underneath, and tidy it all up in one clean move.

ds_judgements_public_ui/sass/includes/_header.scss Outdated Show resolved Hide resolved
ds_judgements_public_ui/sass/includes/_header.scss Outdated Show resolved Hide resolved
locale/en_GB/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
ds_judgements_public_ui/templates/pages/home.html Outdated Show resolved Hide resolved
ds_judgements_public_ui/static/images/tna_logoOLD.svg Outdated Show resolved Hide resolved
Copy link
Contributor

@Terry-Price Terry-Price left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am really happy to help you Donna with these alterations if you want to pair sometime.

@jacksonj04
Copy link
Collaborator

Some touch-ups to move things to make more use of flexbox and tighten up some spacing, and to implement the slimline logo on judgment pages.

localhost_3000_ (1)

localhost_3000_ewhc_ch_2023_1130

@jacksonj04 jacksonj04 requested review from jacksonj04 and removed request for jacksonj04 May 19, 2023 13:13
@Terry-Price
Copy link
Contributor

all good.

@Terry-Price Terry-Price self-requested a review May 19, 2023 14:32
Copy link
Contributor

@Terry-Price Terry-Price left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good, well done Donna,

@Terry-Price Terry-Price added this pull request to the merge queue May 19, 2023
Merged via the queue into main with commit d8b64dd May 19, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants