Skip to content

Commit

Permalink
fix(stark-ui): table action column do not works when language is NL
Browse files Browse the repository at this point in the history
When changing language we got an issue with the name of the column for the Actions in NL
The column definition name was translated bt shouldn't because it used
to get the action in the row object via the 'Actions' property

ISSUES CLOSED: #3391
  • Loading branch information
mhenkens committed Jun 30, 2022
1 parent c728128 commit 20c010e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,8 @@
<stark-table-column
*ngIf="tableRowActions && tableRowActions.actions && tableRowActions.actions.length"
[sortable]="false"
[name]="'STARK.TABLE.ACTIONS' | translate"
[name]="'Actions'"
[headerLabel]="'STARK.TABLE.ACTIONS' | translate"
[stickyEnd]="tableRowActions.isFixed"
>
<ng-template let-context>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1122,7 +1122,7 @@ describe("TableComponent", () => {
});

describe("column actions", () => {
const actionsColumnSelector = "table thead tr th.mat-column-STARK-TABLE-ACTIONS";
const actionsColumnSelector = "table thead tr th.mat-column-Actions";

it("should display the 'actions' column when 'tableRowActions' contains some actions", () => {
hostComponent.tableRowActions = {
Expand Down

0 comments on commit 20c010e

Please sign in to comment.