Skip to content

Commit

Permalink
fix(build): fixed issue with prettier config name with webpack plugin…
Browse files Browse the repository at this point in the history
… and added new scripts at root
  • Loading branch information
dsebastien committed Mar 14, 2018
1 parent 8622e80 commit 51be4f6
Show file tree
Hide file tree
Showing 7 changed files with 18 additions and 19 deletions.
6 changes: 6 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,12 @@ If you want to modify Stark packages (e.g., stark-build, stark-core, ...):

Start hacking :)

If you want to test/validate your changes against the starter, then you can use the following scripts from the root:
* rebuild: `npm run build`
* update the starter: `npm run update-starter`
* run the starter: `npm run starter`


## Releasing a version
* commit all changes to include in the release
* edit the version in package.json
Expand Down
4 changes: 3 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,9 @@
"postinstall:build": "cd packages/stark-build && npm install && cd ../..",
"postinstall:core": "cd packages/stark-core && npm install && cd ../..",
"postinstall:starter": "cd starter && npm install && cd ..",
"build": "sh ./build.sh"
"build": "sh ./build.sh",
"update-starter": "cd starter && npm install && cd ..",
"starter": "cd starter && npm start && cd .."
},
"lint-staged": {
"*.{css,js,json,pcss,scss,ts}": [
Expand Down
4 changes: 1 addition & 3 deletions packages/stark-build/config/webpack.common.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
/**
* @author: @AngularClass
*/
"use strict";

const helpers = require("./helpers");
const commonData = require("./webpack.common-data.js"); // common configuration between environments
Expand Down
7 changes: 2 additions & 5 deletions packages/stark-build/config/webpack.dev.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
/**
* @author: @AngularClass
*/
"use strict";

const helpers = require("./helpers");
const buildUtils = require("./build-utils");
Expand All @@ -11,7 +9,6 @@ const commonData = require("./webpack.common-data.js"); // the settings that are
/**
* Webpack Plugins
*/
const LoaderOptionsPlugin = require("webpack/lib/LoaderOptionsPlugin");
const NamedModulesPlugin = require("webpack/lib/NamedModulesPlugin");
const SourceMapDevToolPlugin = require("webpack/lib/SourceMapDevToolPlugin");

Expand Down Expand Up @@ -212,7 +209,7 @@ module.exports = function() {
* See: https://github.com/JaKXz/stylelint-webpack-plugin
*/
new StylelintPlugin({
configFile: "stylelint.config.js",
configFile: ".stylelintrc",
emitErrors: false,
files: ["src/**/*.?(pc|sc|c|sa)ss"] // pcss|scss|css|sass
}),
Expand Down
6 changes: 2 additions & 4 deletions packages/stark-build/config/webpack.github-deploy.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
/**
* @author: @AngularClass
*/
"use strict";

const fs = require("fs");
const path = require("path");
const helpers = require("./helpers");
const ghDeploy = require("./github-deploy");
const webpackMerge = require("webpack-merge"); // used to merge webpack configs

Expand Down
6 changes: 3 additions & 3 deletions packages/stark-build/config/webpack.prod.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
/**
* @author: @AngularClass
*/
"use strict";

const helpers = require("./helpers");
const buildUtils = require("./build-utils");

Expand Down Expand Up @@ -192,6 +191,7 @@ module.exports = function() {
*/
new ExtractTextPlugin("[name].[contenthash].css"),

// TODO remove since it's probably useless here (defined in webpack.common.js)
new PurifyPlugin() /* buildOptimizer */,

/**
Expand Down
4 changes: 1 addition & 3 deletions packages/stark-build/config/webpack.test.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
/**
* @author: @AngularClass
*/
"use strict";

const helpers = require("./helpers");

Expand Down

0 comments on commit 51be4f6

Please sign in to comment.