Skip to content

Commit

Permalink
fix(stark-all): remove vulnerable event-source-polyfill dependency
Browse files Browse the repository at this point in the history
Vulnerability information: https://security.snyk.io/vuln/SNYK-JS-EVENTSOURCEPOLYFILL-2429580

New browsers now support `EventSource`, this polyfill is no longer necessary
  • Loading branch information
SuperITMan committed Sep 19, 2022
1 parent b745eb1 commit 713239f
Show file tree
Hide file tree
Showing 7 changed files with 41 additions and 86 deletions.
8 changes: 0 additions & 8 deletions docs/POLYFILLS.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,14 +70,6 @@ import "core-js/proposals/reflect-metadata";
import "core-js/modules/web.dom-collections.iterator";
/*****************************************************/

/**
* IE11 and Edge require this to support Server-sent events
* https://caniuse.com/#feat=eventsource
*
* Polyfill: https://github.com/Yaffle/EventSource
*/
import "event-source-polyfill";

/**
* IE11 requires Element.classList for NgClass support on SVG elements
* See: https://caniuse.com/#feat=classlist
Expand Down
75 changes: 32 additions & 43 deletions showcase/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 5 additions & 6 deletions showcase/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -120,15 +120,14 @@
"@angular/router": "^12.2.16",
"@nationalbankbelgium/code-style": "^1.6.0",
"@nationalbankbelgium/ngx-form-errors": "^1.0.0",
"@nationalbankbelgium/stark-core": "file:../dist/packages-dist/stark-core/nationalbankbelgium-stark-core-11.0.0-b0070e3.tgz",
"@nationalbankbelgium/stark-rbac": "file:../dist/packages-dist/stark-rbac/nationalbankbelgium-stark-rbac-11.0.0-b0070e3.tgz",
"@nationalbankbelgium/stark-ui": "file:../dist/packages-dist/stark-ui/nationalbankbelgium-stark-ui-11.0.0-b0070e3.tgz",
"@nationalbankbelgium/stark-core": "file:../dist/packages-dist/stark-core/nationalbankbelgium-stark-core-10.2.0-b745eb10-1663582743.tgz",
"@nationalbankbelgium/stark-rbac": "file:../dist/packages-dist/stark-rbac/nationalbankbelgium-stark-rbac-10.2.0-b745eb10-1663582743.tgz",
"@nationalbankbelgium/stark-ui": "file:../dist/packages-dist/stark-ui/nationalbankbelgium-stark-ui-10.2.0-b745eb10-1663582743.tgz",
"@uirouter/visualizer": "~7.2.1",
"angular-in-memory-web-api": "~0.11.0",
"basscss": "~8.1.0",
"core-js": "~3.17.2",
"eligrey-classlist-js-polyfill": "~1.2.20180112",
"event-source-polyfill": "~1.0.22",
"hammerjs": "^2.0.8",
"http-server": "~14.1.0",
"ngrx-store-logger": "~0.2.2",
Expand All @@ -138,8 +137,8 @@
},
"devDependencies": {
"@compodoc/compodoc": "1.1.19",
"@nationalbankbelgium/stark-build": "file:../dist/packages-dist/stark-build/nationalbankbelgium-stark-build-11.0.0-b0070e3.tgz",
"@nationalbankbelgium/stark-testing": "file:../dist/packages-dist/stark-testing/nationalbankbelgium-stark-testing-11.0.0-b0070e3.tgz",
"@nationalbankbelgium/stark-build": "file:../dist/packages-dist/stark-build/nationalbankbelgium-stark-build-10.2.0-b745eb10-1663582743.tgz",
"@nationalbankbelgium/stark-testing": "file:../dist/packages-dist/stark-testing/nationalbankbelgium-stark-testing-10.2.0-b745eb10-1663582743.tgz",
"@types/core-js": "~2.5.4",
"@types/hammerjs": "~2.0.39",
"@types/node": "^12.20.24",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -242,14 +242,6 @@ import "core-js/proposals/reflect-metadata";
import "core-js/modules/web.dom-collections.iterator";
/*****************************************************/
/**
* IE11 and Edge require this to support Server-sent events
* https://caniuse.com/#feat=eventsource
*
* Polyfill: https://github.com/Yaffle/EventSource
*/
import "event-source-polyfill";
/**
* IE11 requires Element.classList for NgClass support on SVG elements
* See: https://caniuse.com/#feat=classlist
Expand Down
8 changes: 0 additions & 8 deletions showcase/src/polyfills.browser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,6 @@ import "core-js/proposals/reflect-metadata";
*/
import "core-js/modules/web.dom-collections.iterator";

/**
* IE11 and Edge require this to support Server-sent events
* https://caniuse.com/#feat=eventsource
*
* Polyfill: https://github.com/Yaffle/EventSource
*/
import "event-source-polyfill";

/**
* IE11 requires Element.classList for NgClass support on SVG elements
* See: https://caniuse.com/#feat=classlist
Expand Down
9 changes: 4 additions & 5 deletions starter/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -121,12 +121,11 @@
"@angular/platform-server": "^12.2.16",
"@angular/router": "^12.2.16",
"@nationalbankbelgium/code-style": "^1.6.0",
"@nationalbankbelgium/stark-core": "file:../dist/packages-dist/stark-core/nationalbankbelgium-stark-core-10.2.0-87470353-1628164059.tgz",
"@nationalbankbelgium/stark-ui": "file:../dist/packages-dist/stark-ui/nationalbankbelgium-stark-ui-10.2.0-87470353-1628164059.tgz",
"@nationalbankbelgium/stark-core": "file:../dist/packages-dist/stark-core/nationalbankbelgium-stark-core-10.2.0-b745eb10-1663582743.tgz",
"@nationalbankbelgium/stark-ui": "file:../dist/packages-dist/stark-ui/nationalbankbelgium-stark-ui-10.2.0-b745eb10-1663582743.tgz",
"@uirouter/visualizer": "~7.2.1",
"core-js": "~3.21.1",
"eligrey-classlist-js-polyfill": "~1.2.20180112",
"event-source-polyfill": "~1.0.22",
"hammerjs": "^2.0.8",
"http-server": "~14.1.0",
"ngrx-store-logger": "~0.2.2",
Expand All @@ -136,8 +135,8 @@
},
"devDependencies": {
"@compodoc/compodoc": "1.1.19",
"@nationalbankbelgium/stark-build": "file:../dist/packages-dist/stark-build/nationalbankbelgium-stark-build-10.2.0-87470353-1628164059.tgz",
"@nationalbankbelgium/stark-testing": "file:../dist/packages-dist/stark-testing/nationalbankbelgium-stark-testing-10.2.0-87470353-1628164059.tgz",
"@nationalbankbelgium/stark-build": "file:../dist/packages-dist/stark-build/nationalbankbelgium-stark-build-10.2.0-b745eb10-1663582743.tgz",
"@nationalbankbelgium/stark-testing": "file:../dist/packages-dist/stark-testing/nationalbankbelgium-stark-testing-10.2.0-b745eb10-1663582743.tgz",
"@types/core-js": "~2.5.4",
"@types/hammerjs": "~2.0.39",
"@types/node": "^12.20.13",
Expand Down
8 changes: 0 additions & 8 deletions starter/src/polyfills.browser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,6 @@ import "core-js/proposals/reflect-metadata";
*/
import "core-js/modules/web.dom-collections.iterator";

/**
* IE11 and Edge require this to support Server-sent events
* https://caniuse.com/#feat=eventsource
*
* Polyfill: https://github.com/Yaffle/EventSource
*/
import "event-source-polyfill";

/**
* IE11 requires Element.classList for NgClass support on SVG elements
* See: https://caniuse.com/#feat=classlist
Expand Down

0 comments on commit 713239f

Please sign in to comment.