feat(showcase): adapt generic-search demo to use public results$ va…

…riable directly in template
NationalBankBelgium · Nov 17, 2021 · 733e236 · 733e236
1 parent 54fb29a
commit 733e236
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 21 deletions.
diff --git a/showcase/src/app/demo-ui/pages/generic-search/demo-generic-search-page.component.html b/showcase/src/app/demo-ui/pages/generic-search/demo-generic-search-page.component.html
@@ -26,7 +26,7 @@ <h1 translate>SHOWCASE.DEMO.SHARED.EXAMPLE_VIEWER_LIST</h1>
 			htmlId="demo-generic-search-table"
 			[columnProperties]="columnsProperties"
 			[paginationConfig]="paginationConfig"
-			[data]="searchResults"
+			[data]="results$ | async"
 			[starkProgressIndicator]="progressIndicatorConfig"
 		>
 			<header><h1 class="mb0" translate>SHOWCASE.DEMO.GENERIC_SEARCH.SEARCH_RESULTS</h1></header>

diff --git a/showcase/src/app/demo-ui/pages/generic-search/demo-generic-search-page.component.ts b/showcase/src/app/demo-ui/pages/generic-search/demo-generic-search-page.component.ts
@@ -1,4 +1,4 @@
-import { Component, Inject, OnDestroy, OnInit } from "@angular/core";
+import { Component, Inject } from "@angular/core";
 import { STARK_LOGGING_SERVICE, StarkLoggingService } from "@nationalbankbelgium/stark-core";
 import { ReferenceLink } from "../../../shared";
 import {
@@ -15,9 +15,7 @@ import { DemoGenericService } from "./services";
 	selector: "demo-generic-search",
 	templateUrl: "./demo-generic-search-page.component.html"
 })
-export class DemoGenericSearchPageComponent
-	extends AbstractStarkSearchComponent<HeroMovie, HeroMovieSearchCriteria>
-	implements OnInit, OnDestroy {
+export class DemoGenericSearchPageComponent extends AbstractStarkSearchComponent<HeroMovie, HeroMovieSearchCriteria> {
 	public hideSearch = false;
 
 	public columnsProperties: StarkTableColumnProperties[] = [
@@ -40,7 +38,6 @@ export class DemoGenericSearchPageComponent
 			isSortable: true
 		}
 	];
-	public searchResults?: HeroMovie[];
 	public paginationConfig: StarkPaginationConfig = {
 		isExtended: false,
 		itemsPerPage: 10,
@@ -73,19 +70,4 @@ export class DemoGenericSearchPageComponent
 		this.performSearchOnInit = true; // Turn on automatic search (last search criteria)
 		this.preserveLatestResults = true; // Keep a reference to the latest results in the latestResults variable
 	}
-
-	/**
-	 * Component lifecycle hook
-	 */
-	public ngOnInit(): void {
-		super.ngOnInit();
-		this.results$.subscribe((genericObjects: HeroMovie[]) => (this.searchResults = genericObjects));
-	}
-
-	/**
-	 * Component lifecycle hook
-	 */
-	public ngOnDestroy(): void {
-		super.ngOnDestroy();
-	}
 }