feat(stark-testing): improve karma config for ng test usage

BREAKING CHANGE:
Adapt test ci script in "package.json":
  ```
  // BEFORE
  "test-fast:ci": "cross-env CI=1 npm run ng test --code-coverage",

  // AFTER
  "test-fast:ci": "npm run ng test -- --watch=false --code-coverage",
  ```

package.json

@@ -216,9 +216,9 @@
     "test:starter:e2e": "cd starter && npm run e2e && cd ../..",
     "test:ci:all": "npm run test:ci:stark-core && npm run test:ci:stark-ui && npm run test:ci:stark-rbac && npm run test:ci:starter && npm run test:ci:showcase",
     "test:ci:packages": "npm run test:ci:stark-core && npm run test:ci:stark-ui && npm run test:ci:stark-rbac",
-    "test:ci:stark-core": "cross-env CI=true ng test stark-core --code-coverage",
-    "test:ci:stark-rbac": "cross-env CI=true ng test stark-rbac --code-coverage",
-    "test:ci:stark-ui": "cross-env CI=true ng test stark-ui --code-coverage",
+    "test:ci:stark-core": "ng test stark-core --watch=false --code-coverage",
+    "test:ci:stark-rbac": "ng test stark-rbac --watch=false --code-coverage",
+    "test:ci:stark-ui": "ng test stark-ui --watch=false --code-coverage",
     "test:ci:showcase": "cd showcase && npm run test-fast:ci && cd ../..",
     "test:ci:starter": "cd starter && npm run test-fast:ci && cd ../..",
     "test:ci:coveralls:combined": "node combine-packages-coverage.js",

packages/stark-core/package.json

@@ -62,7 +62,7 @@
     "test": "npm run lint && npm run test-fast",
     "test:ci": "npm run lint && npm run test-fast:ci",
     "test-fast": "npm run ng test",
-    "test-fast:ci": "../../node_modules/.bin/cross-env CI=1 npm run ng test -- --code-coverage",
+    "test-fast:ci": "ng test --watch=false --code-coverage",
     "tsc": "node ../../node_modules/typescript/bin/tsc -p ./tsconfig.json",
     "tslint": "node ../../node_modules/tslint/bin/tslint",
     "tslint-check": "tslint-config-prettier-check ./tslint.json"

packages/stark-rbac/package.json

@@ -37,7 +37,7 @@
     "test": "npm run lint && npm run test-fast",
     "test:ci": "npm run lint && npm run test-fast:ci",
     "test-fast": "npm run ng test",
-    "test-fast:ci": "../../node_modules/.bin/cross-env CI=1 npm run ng test -- --code-coverage",
+    "test-fast:ci": "ng test --watch=false --code-coverage",
     "tsc": "node ../../node_modules/typescript/bin/tsc -p ./tsconfig.json",
     "tslint": "node ../../node_modules/tslint/bin/tslint",
     "tslint-check": "tslint-config-prettier-check ./tslint.json"

packages/stark-testing/karma.conf.js

@@ -1,6 +1,7 @@
 // Helpers
 const helpers = require("./helpers");
 const ciDetect = require("@npmcli/ci-detect");
+const isCI = process.argv.indexOf("--watch=false") > -1 || !!ciDetect();
 
 const rawKarmaConfig = {
 	// base path that will be used to resolve all patterns (e.g. files, exclude)
@@ -30,7 +31,7 @@ const rawKarmaConfig = {
 	// available reporters: https://npmjs.org/browse/keyword/karma-reporter
 	// https://www.npmjs.com/package/karma-junit-reporter
 	// https://www.npmjs.com/package/karma-spec-reporter
-	reporters: !!ciDetect() ? ["mocha", "progress"] : ["mocha", "progress", "kjhtml"],
+	reporters: isCI ? ["mocha", "progress"] : ["mocha", "progress", "kjhtml"],
 
 	// web server port
 	port: 9876,
@@ -54,14 +55,14 @@ const rawKarmaConfig = {
 
 	// start these browsers
 	// available browser launchers: https://npmjs.org/browse/keyword/karma-launcher
-	browsers: !!ciDetect() ? ["ChromeHeadlessNoSandbox"] : ["Chrome"],
+	browsers: isCI ? ["ChromeHeadlessNoSandbox"] : ["Chrome"],
 
 	// Continuous Integration mode
 	// if true, Karma captures browsers, runs the tests and exits
-	singleRun: !!ciDetect(),
+	singleRun: isCI,
 
 	// If true, tests restart automatically if a file is changed
-	restartOnFileChange: !ciDetect(),
+	restartOnFileChange: !isCI,
 
 	// Timeout settings
 	browserNoActivityTimeout: 30000,
@@ -94,5 +95,6 @@ module.exports = {
 	default: function (config) {
 		config.set(rawKarmaConfig);
 	},
-	rawKarmaConfig: rawKarmaConfig
+	rawKarmaConfig: rawKarmaConfig,
+	isCITest: isCI
 };

packages/stark-ui/package.json

@@ -56,7 +56,7 @@
     "test": "npm run lint && npm run test-fast",
     "test:ci": "npm run lint && npm run test-fast:ci",
     "test-fast": "npm run ng test",
-    "test-fast:ci": "../../node_modules/.bin/cross-env CI=1 npm run ng test -- --code-coverage",
+    "test-fast:ci": "ng test --watch=false --code-coverage",
     "tsc": "node ../../node_modules/typescript/bin/tsc -p ./tsconfig.json",
     "tslint": "node ../../node_modules/tslint/bin/tslint",
     "tslint-check": "tslint-config-prettier-check ./tslint.json"

showcase/package.json

@@ -85,7 +85,7 @@
     "test": "npm run lint && npm run test-fast",
     "test:ci": "npm run lint && npm run test-fast:ci",
     "test-fast": "npm run ng test",
-    "test-fast:ci": "cross-env CI=1 npm run ng test --code-coverage",
+    "test-fast:ci": "npm run ng -- test --watch=false --code-coverage",
     "tsc": "tsc",
     "tslint": "tslint",
     "tslint-check": "tslint-config-prettier-check ./tslint.json",

starter/package.json

@@ -82,7 +82,7 @@
     "test": "npm run lint && npm run test-fast",
     "test:ci": "npm run lint && npm run test-fast:ci",
     "test-fast": "npm run ng test",
-    "test-fast:ci": "cross-env CI=1 npm run ng test --code-coverage",
+    "test-fast:ci": "npm run ng test -- --watch=false --code-coverage",
     "tsc": "tsc",
     "tslint": "tslint",
     "tslint-check": "tslint-config-prettier-check ./tslint.json",