Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

showcase: old files not deleted from 'latest' folder causing some files not be overwritten by the new ones #1138

Closed
christophercr opened this issue Feb 18, 2019 · 0 comments · Fixed by #1140

Comments

@christophercr
Copy link
Collaborator

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[X] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

Not all the new content is copied to the latest folder. This happens when the new files have exactly the same name and size as the old ones i.e. the index.html file. This causes the Showcase to be completely broken and not loading at all due to wrong references to JS files.
`

Expected behavior

The deployed Showcase under the latest on GhPages should work correctly after every release.

Minimal reproduction of the problem with instructions

Open the latest version of the Showcase: https://stark.nbb.be

What is the motivation / use case for changing the behavior?

Fully working Showcase app.

Environment


Stark version: 10.0.0-beta.4

@christophercr christophercr added this to the 10.0.0-beta.5 milestone Feb 18, 2019
@christophercr christophercr self-assigned this Feb 18, 2019
@christophercr christophercr changed the title showcase: old files not removed from 'latest' folder causing some files not be overwritten by the new ones showcase: old files not deleted from 'latest' folder causing some files not be overwritten by the new ones Feb 18, 2019
christophercr added a commit to christophercr/stark that referenced this issue Feb 18, 2019
@christophercr christophercr added this to To do in 10.0.0-beta.5 via automation Feb 18, 2019
christophercr added a commit to christophercr/stark that referenced this issue Feb 18, 2019
@christophercr christophercr moved this from To do to Needs review in 10.0.0-beta.5 Feb 18, 2019
10.0.0-beta.5 automation moved this from Needs review to Done Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
10.0.0-beta.5
  
Done
Development

Successfully merging a pull request may close this issue.

1 participant