Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: button - implement theming #476

Closed
catlabs opened this issue Jun 29, 2018 · 0 comments · Fixed by #517
Closed

ui: button - implement theming #476

catlabs opened this issue Jun 29, 2018 · 0 comments · Fixed by #517
Labels
comp: stark-ui type: feature
Projects
10.0.0-alpha.4
Milestone
10.0.0-alpha.4

Comments

@catlabs
Copy link
Contributor

catlabs commented Jun 29, 2018 •
edited

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[x] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

Add a theming for the buttons

Suggestions

  • Having 3 size for buttons: small, medium, large
  • Add white color for buttons above a dark background
  • Change the buttons in the rewrote components that used them
@catlabs catlabs added this to the 10.0.0-alpha.4 milestone Jun 29, 2018
@catlabs catlabs self-assigned this Jun 29, 2018
catlabs added a commit to catlabs/stark that referenced this issue Jul 17, 2018
@catlabs
feat(stark-ui): implementation of the button's theme
d314f91 
ISSUES CLOSED: NationalBankBelgium#476
catlabs added a commit to catlabs/stark that referenced this issue Jul 17, 2018
@catlabs
feat(stark-ui): implementation of the button's theme
4cd436b 
ISSUES CLOSED: NationalBankBelgium#476
@catlabs catlabs mentioned this issue Jul 17, 2018
Merged
3 tasks
catlabs added a commit to catlabs/stark that referenced this issue Jul 17, 2018
@catlabs
feat(stark-ui): implementation of the button's theme
7be2cff 
ISSUES CLOSED: NationalBankBelgium#476
catlabs added a commit to catlabs/stark that referenced this issue Jul 18, 2018
@catlabs
feat(stark-ui): implementation of the button's theme
ea1db01 
ISSUES CLOSED: NationalBankBelgium#476
catlabs added a commit to catlabs/stark that referenced this issue Jul 18, 2018
@catlabs
feat(stark-ui): implementation of the button's theme
73d28ea 
ISSUES CLOSED: NationalBankBelgium#476
catlabs added a commit to catlabs/stark that referenced this issue Jul 18, 2018
@catlabs
feat(stark-ui): implementation of the button's theme
ccf1384 
ISSUES CLOSED: NationalBankBelgium#476
catlabs added a commit to catlabs/stark that referenced this issue Jul 18, 2018
@catlabs
feat(stark-ui): implementation of the button's theme
240f6f0 
ISSUES CLOSED: NationalBankBelgium#476
catlabs added a commit to catlabs/stark that referenced this issue Jul 18, 2018
@catlabs
feat(stark-ui): implementation of the button's theme
c49b6ef 
ISSUES CLOSED: NationalBankBelgium#476
@SuperITMan SuperITMan added this to Done in 10.0.0-alpha.4 Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: stark-ui type: feature
Projects
No open projects
10.0.0-alpha.4
  
Done
Milestone
10.0.0-alpha.4
Development

Successfully merging a pull request may close this issue.

feat(stark-ui): implement the button's theme catlabs/stark
2 participants
@catlabs @christophercr