Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: showcase - "RangeError: Maximum call stack size exceeded" due to Angular build-optimizer on prettier/parser-typescript.js #566

Closed
christophercr opened this issue Jul 30, 2018 · 1 comment
Closed

build: showcase - "RangeError: Maximum call stack size exceeded" due to Angular build-optimizer on prettier/parser-typescript.js #566

christophercr opened this issue Jul 30, 2018 · 1 comment
Labels
comp: stark-build Stark Build comp: stark-ui type: bug
Projects
10.0.0-alpha.5
Milestone
10.0.0-alpha.5

Comments

@christophercr
Copy link
Collaborator

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[X] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

Angular build-optimizer throws an error while building the production build with webpack:

ERROR in ./node_modules/prettier/parser-typescript.js
Module build failed (from ./node_modules/@angular-devkit/build-optimizer/src/build-optimizer/webpack-loader.js):
RangeError: Maximum call stack size exceeded
    at Object.visitEachChild (/home/travis/build/NationalBankBelgium/stark/showcase/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:56952:28)
    at visitor (/home/travis/build/NationalBankBelgium/stark/showcase/node_modules/@angular-devkit/build-optimizer/src/transforms/wrap-enums.js:53:23)
    at visitNode (/home/travis/build/NationalBankBelgium/stark/showcase/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:56836:23)
    at Object.visitEachChild (/home/travis/build/NationalBankBelgium/stark/showcase/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:57078:46)
    at visitor (/home/travis/build/NationalBankBelgium/stark/showcase/node_modules/@angular-devkit/build-optimizer/src/transforms/wrap-enums.js:53:23)
    at visitNode (/home/travis/build/NationalBankBelgium/stark/showcase/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:56836:23)
    at Object.visitEachChild (/home/travis/build/NationalBankBelgium/stark/showcase/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:57078:46)
    at visitor (/home/travis/build/NationalBankBelgium/stark/showcase/node_modules/@angular-devkit/build-optimizer/src/transforms/wrap-enums.js:53:23)
    at visitNode (/home/travis/build/NationalBankBelgium/stark/showcase/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:56836:23)
    at Object.visitEachChild (/home/travis/build/NationalBankBelgium/stark/showcase/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:57078:46)
    at visitor (/home/travis/build/NationalBankBelgium/stark/showcase/node_modules/@angular-devkit/build-optimizer/src/transforms/wrap-enums.js:53:23)
    at visitNode (/home/travis/build/NationalBankBelgium/stark/showcase/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:56836:23)
    at Object.visitEachChild (/home/travis/build/NationalBankBelgium/stark/showcase/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:57078:46)
    at visitor (/home/travis/build/NationalBankBelgium/stark/showcase/node_modules/@angular-devkit/build-optimizer/src/transforms/wrap-enums.js:53:23)
    at visitNode (/home/travis/build/NationalBankBelgium/stark/showcase/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:56836:23)
    at Object.visitEachChild (/home/travis/build/NationalBankBelgium/stark/showcase/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:57078:46)
    at visitor (/home/travis/build/NationalBankBelgium/stark/showcase/node_modules/@angular-devkit/build-optimizer/src/transforms/wrap-enums.js:53:23)
    at visitNode (/home/travis/build/NationalBankBelgium/stark/showcase/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:56836:23)
    at Object.visitEachChild (/home/travis/build/NationalBankBelgium/stark/showcase/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:57078:46)
    at visitor (/home/travis/build/NationalBankBelgium/stark/showcase/node_modules/@angular-devkit/build-optimizer/src/transforms/wrap-enums.js:53:23)
    at visitNode (/home/travis/build/NationalBankBelgium/stark/showcase/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:56836:23)
    at Object.visitEachChild (/home/travis/build/NationalBankBelgium/stark/showcase/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:57078:46)
    at visitor (/home/travis/build/NationalBankBelgium/stark/showcase/node_modules/@angular-devkit/build-optimizer/src/transforms/wrap-enums.js:53:23)
    at visitNode (/home/travis/build/NationalBankBelgium/stark/showcase/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:56836:23)
    at Object.visitEachChild (/home/travis/build/NationalBankBelgium/stark/showcase/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:57078:46)
    at visitor (/home/travis/build/NationalBankBelgium/stark/showcase/node_modules/@angular-devkit/build-optimizer/src/transforms/wrap-enums.js:53:23)
    at visitNode (/home/travis/build/NationalBankBelgium/stark/showcase/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:56836:23)
    at Object.visitEachChild (/home/travis/build/NationalBankBelgium/stark/showcase/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:57078:46)
    at visitor (/home/travis/build/NationalBankBelgium/stark/showcase/node_modules/@angular-devkit/build-optimizer/src/transforms/wrap-enums.js:53:23)
    at visitNode (/home/travis/build/NationalBankBelgium/stark/showcase/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:56836:23)
    at Object.visitEachChild (/home/travis/build/NationalBankBelgium/stark/showcase/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:57078:46)
    at visitor (/home/travis/build/NationalBankBelgium/stark/showcase/node_modules/@angular-devkit/build-optimizer/src/transforms/wrap-enums.js:53:23)
    at visitNode (/home/travis/build/NationalBankBelgium/stark/showcase/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:56836:23)
    at Object.visitEachChild (/home/travis/build/NationalBankBelgium/stark/showcase/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:57078:46)
    at visitor (/home/travis/build/NationalBankBelgium/stark/showcase/node_modules/@angular-devkit/build-optimizer/src/transforms/wrap-enums.js:53:23)
    at visitNode (/home/travis/build/NationalBankBelgium/stark/showcase/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:56836:23)
 @ ./node_modules/@nationalbankbelgium/stark-ui/fesm5/stark-ui.js 410:4-41
 @ ./src/app/app.module.ngfactory.js
 @ ./src/main.browser.ts

Expected behavior

No errors while generating the webpack production build.

Minimal reproduction of the problem with instructions

Run npm run build:aot:prod command in the showcase on Node 6.

What is the motivation / use case for changing the behavior?

Stable build process.

Environment


Angular version: 6.0.9
 
For Tooling issues:
- Node version: 6.X
- Platform:  ALL
@christophercr christophercr self-assigned this Jul 30, 2018
@christophercr christophercr added this to the 10.0.0-alpha.4 milestone Jul 30, 2018
@christophercr christophercr added this to To do in 10.0.0-alpha.4 via automation Jul 30, 2018
@christophercr christophercr removed this from To do in 10.0.0-alpha.4 Jul 30, 2018
@christophercr christophercr removed this from the 10.0.0-alpha.4 milestone Jul 30, 2018
@SuperITMan SuperITMan added this to the 10.0.0-alpha.5 milestone Jul 30, 2018
@SuperITMan SuperITMan added this to To do in 10.0.0-alpha.5 via automation Jul 30, 2018
SuperITMan referenced this issue in SuperITMan/stark Jul 31, 2018
@ageorges-nbb
fix(build): add an argument for build prod when it is a Test CI. Adap…
2da0c48 
…t travis.yml to use it

ISSUES CLOSED: #572 #566
SuperITMan referenced this issue in SuperITMan/stark Jul 31, 2018
@ageorges-nbb
fix(build): add an argument for build prod when it is a Test CI. Adap…
2ee274d 
…t travis.yml to use it

ISSUES CLOSED: #572 #566
SuperITMan referenced this issue in SuperITMan/stark Jul 31, 2018
@ageorges-nbb
fix(build): add an argument for build prod when it is a Test CI. Adap…
b954903 
…t travis.yml to use it

ISSUES CLOSED: #572 #566
@SuperITMan SuperITMan mentioned this issue Jul 31, 2018
Merged
3 tasks
@christophercr
Copy link
Collaborator Author

Closed by #576

10.0.0-alpha.5 automation moved this from To do to Done Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: stark-build Stark Build comp: stark-ui type: bug
Projects
No open projects
10.0.0-alpha.5
  
Done
Milestone
10.0.0-alpha.5
Development

No branches or pull requests
2 participants
@christophercr @SuperITMan