Provide generic (fallback) client endpoint methods #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor and compact all convenience endpoint methods to use these generic methods. While the implementation isn't any shorter, it's more powerful and less redundant. NBClient now at the base level supports any endpoint returning a list, single items, single value, or empty body. For GET, query string parameters are also much easier to add. Also removes LegacyPaginationEndpoints implementation.
...to turn off. See comment for details.
hlfcoding
force-pushed
the
peng/generic-client-endpoint-methods
branch
from
854e4d6
to
7153d32
Compare
hlfcoding
added a commit
that referenced
this pull request
Mar 12, 2016
…t-methods Provide generic (fallback) client endpoint methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #42. Changes a lot of the internal
NBClientinterface.