Final bug fixes for 1.3.0 #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlfcoding
force-pushed
the
peng/final-bug-fixes
branch
2 times, most recently
from
fde7045
to
351baef
Compare
Proxying was failing and returning 500's on any DELETE. The solve is to include the port for the local url.
hlfcoding
force-pushed
the
peng/final-bug-fixes
branch
from
351baef
to
4820525
Compare
hlfcoding
force-pushed
the
peng/final-bug-fixes
branch
from
4820525
to
be802a5
Compare
Bug was crashing NBClientExample when refreshing.
Pretty common check against JSON dictionaries.
Was causing infinite load-more behavior in NBClientExample. Now that nextPageURLString can actually be nil, the assertion helper can fail depending on server data, so that assertion is unreliable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #42.