Docker HUB version of Nativefier out of date

[Fmstrat]

The Docker HUB version of Nativefier under your name is 8 months behind GitHub:

https://hub.docker.com/r/jiahaog/nativefier

Any chance of activating the auto-build against master?

[mxdpeep]

probably not, he is not active on this project, he works on Flutter

[gaving]

I'm also interested in this one, currently building and pushing this myself internally at my company but would prefer to use an official docker image!

[snpranav]

Hi @gaving and @Fmstrat,
I have sent in a pull request (#1014) to update the README.md file on this repository, but until then I just added the docker images to docker hub - https://hub.docker.com/r/snpranav/nativefier.

The docker image is being maintained at https://gitlab.com/snpranav/nativefier-docker with auto-build master using GitLab CI that runs every day.

Hope this helps 😄

[gaving]

@snpranav Great stuff 👍 - would be perfect if that got officially merged in!

[Fmstrat]

While I do applaud and like the idea of handling the push to Docker HUB if it's not coming out of this repo, I would prefer an official image that is auto-built from this repo directly. There is already a Dockerfile, and if @jiahaog or @ronjouch were to set up (or assign someone set up) a Docker HUB account, it would be trivial to build directly from here.

[ronjouch]

Hi folks. Yeah I'd like an official image too, and I will not vet a third-party in README, so although I'm thankful for the initiative @snpranav, I closed your PR.

I'm privately reaching out to Jia (original author of Nativefier, no longer working on it), asking him to fix the build or transfer me access to hub.docker.com/nativefier. Thanks for the comprehension everybody.

[snpranav]

Sure. I thought keeping all the code on my end open-source would solve this trust issue, but I understand why it still might be a problem for some people.

Nevertheless, thanks for all the appreciation :)

[jiahaog]

I turned on the auto build on dockerhub, please let us know if there are any issues!

[ronjouch]

I turned on the auto build on dockerhub, please let us know if there are any issues!

Thanks Jia!

---

Image users, do you confirm image jiahaog/nativefier works well? If it does I'll restore the usage instructions in README (I moved them to https://github.com/jiahaog/nativefier/blob/master/Dockerfile#L1-L15 ).

[gaving]

🙌 Thanks @jiahaog and @ronjouch!

Working well:-

❯ docker run jiahaog/nativefier:latest --version
9.1.0

And tried it launching a test site, no issues.

[mattruzzi]

The auto build isn't working.

$ docker run jiahaog/nativefier:latest --version
9.1.0

The latest version is currently 42.0.2.

[snpranav]

@mattruzzi After looking at the builds on docker hub, I noticed that the last build was for the commit 8e8cd24 which was on Aug 2, 2020 (5 months ago). The auto-build seems to have stopped after that.

I've attached a screenshot from the docker hub builds page.

[ronjouch]

Thanks for the heads up, @mattruzzi @snpranav ! I pinged @jiahaog to look at it.

[gaving]

Latest image seems to have been updated 14 days ago now at least.

Though not sure if the recently pushed 42.1.0 will get updated on it automatically...

[ronjouch]

Latest image seems to have been updated 14 days ago now at least.

Though not sure if the recently pushed 42.1.0 will get updated on it automatically...

@gaving thanks for the ping. Jia tried something two weeks ago, but indeed the build still doesn't trigger. I pinged him, he's going to look at it.

[gaving]

Thanks for your maintenance efforts!

I wonder if there's any appetite for nativefier to be transferred to a github/docker organisation and maintained via that - great bit of software and I know a lot of people depending on it where I am now.

[ronjouch]

@gaving

Thanks for your maintenance efforts!

Welcome and thanks for the kind words 🙂

I wonder if there's any appetite for nativefier to be transferred to a github/docker organisation and maintained via that.

I too would like Nativefier to be moved into an org, yes, if only to solve our terrible bus factor. Jia (original author) is the sole owner of {npm, github, docker} admin bits. If he disappears tomorrow, we're toast.

Other reasons:

1. Pull into the org Nativefier's sister projects (icons, page-icon, gitcloud), to easily grant/revoke accesses on them too for me and future maintainers.
2. [Just an idea, not something I plan to work on] Also, the icons project could be expanded into a more general nativefier-community-options project of the organization, where people could contribute good settings & icons for the sites they use, avoiding tons of "WhatsApp/xyz stopped working" questions by sharing the necessary options for sites needing them.

I'll brew an email to Jia.

[gaving]

All sounds great to me. Good luck with the email!

[ronjouch]

Docker builds appear to be working for now (see chat in #1100 ). With that, closing. Feel free to shout here if Docker Hub builds start lagging again.

---

Also @gaving , good news, Jia put in the grunt work to move Nativefier to {github,npm,docker} orgs, to which I have access, improving our bus factor 🙂.

[gaving]

@ronjouch Great stuff, the project has a bright future! Thanks for all the maintenance efforts.

[mattruzzi]

@ronjouch It is lagging again.

$ docker run --rm nativefier/nativefier --version
45.0.0
$ npx nativefier --version
45.0.5

https://hub.docker.com/r/nativefier/nativefier

[mattruzzi]

@ronjouch @snpranav Should we reconsider #1100?

[snpranav]

@mattruzzi @ronjouch I think the pull request made in #1100 will solve a lot of the issues with docker builds constantly failing. Currently, it takes a significant amount of time for @jiahaog to revert back and to fix the auto builds to docker hub every time it fails, so I would advocate for reconsidering it since it would permanently solve a lot of the auto-build issues caused by docker hub.

[ronjouch]

Merged @snpranav's PR, tweaked a few knobs, confirmed working and pushing at docker hub / nativefier/nativefier: