use Array.isArray instead of ɵisListLikeIterable which is deprecated #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpaaske
reviewed
Apr 19, 2023
| @@ -86,7 +85,7 @@ export abstract class TemplatedItemsComponent implements DoCheck, OnDestroy, Aft | |||
| if (value instanceof ObservableArray) { | |||
| needDiffer = false; | |||
| } | |||
| if (needDiffer && !this._differ && isListLikeIterable(value)) { | |||
| if (needDiffer && !this._differ && Array.isArray(value)) { | |||
There was a problem hiding this comment.
isListLikeIterable does a little more than just isArray(), do we need it here as well?
export function isListLikeIterable(obj: any): boolean {
if (!isJsObject(obj)) return false;
return Array.isArray(obj) ||
(!(obj instanceof Map) && // JS Map are iterables but return entries as [k, v]
Symbol.iterator in obj); // JS Iterable have a Symbol.iterator prop
}
|
@ubaidazad thanks it should be fixed in this commit 68f4255 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses bug #34 by fixing the issue
ɵisListLikeIterablewhich is imported from@angular/coreand is deprecated in latest versions.