Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ViewNode insertBefore and appendChild issues #809

Closed
delaneyb opened this issue Mar 4, 2021 · 1 comment · Fixed by #811
Closed

ViewNode insertBefore and appendChild issues #809

delaneyb opened this issue Mar 4, 2021 · 1 comment · Fixed by #811
Labels
priority:normal

Comments

@delaneyb
Copy link
Contributor

delaneyb commented Mar 4, 2021

Version

2.8.3

Reproduction link

https://play.nativescript.org/?template=play-vue&id=pG3Voz

Platform and OS info

Android 10 / NativeScript 7, iOS 14.4 / NativeScript 7.2.0

Steps to reproduce

Tap on the StackLayout

What is expected?

The Above/Below text should appear above or below the line respectively

What is actually happening?

The views appear in the wrong place

This has been the cause of several nasty bugs I've seen crop up over the last 18 months where views simply do not appear or are in the wrong order. Related to #127

I have found 2 issues that resolve this I am putting a PR together for.
This was referenced Mar 4, 2021
Closed
Merged
delaneyb added a commit to Yellowbox-AU/nativescript-vue that referenced this issue Mar 10, 2021
@delaneyb
test: add test case for nativescript-vue#809
a2165a1
rigor789 pushed a commit that referenced this issue Mar 10, 2021
@delaneyb
fix: incorrect nextSibling of prevSibling in appendChild/insertBefore (…
5156f20 
…#811)

fixes #809

* chore: remove unnecessary check from appendChild

* fix: remove node before appending if already a child

* fix: set nextSibling of prevSibling upon insertion (fixed)

* test: add test case for #809
@nativescript-vue-bot
Copy link
Collaborator

We are locking this issue because it has been closed for more than 14 days.

If the issue comes up again please open a new issue with additional details.

@nativescript-vue nativescript-vue locked as resolved and limited conversation to collaborators Mar 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
priority:normal
Milestone
No milestone
2 participants
@delaneyb @nativescript-vue-bot