Implement actionbar #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EddyVerbruggen
commented
Aug 1, 2017
| }, | ||
|
|
||
| mounted() { | ||
| const refKeys = Object.keys(this.$root.$refs) | ||
|
|
||
| // TODO figure out how to find the Page object without using the $refs property |
There was a problem hiding this comment.
If there is any better way, please let me know, but for now this suffices IMO.
EddyVerbruggen
commented
Aug 1, 2017
| icon: { | ||
| type: String | ||
| }, | ||
| 'android.position': { |
There was a problem hiding this comment.
It doesn't seem possible to do:
props: {
android: {
position: {
type: String
}
}
}.. but this works fine.
There was a problem hiding this comment.
That is fine, and it's by design afaik
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #13
Please review. I've added a few remarks to the code to clarify a few choices.