Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blacklist IP Tagging not working #206

Closed
sdupreez opened this issue Oct 24, 2019 · 1 comment
Closed

Blacklist IP Tagging not working #206

sdupreez opened this issue Oct 24, 2019 · 1 comment
Labels
bug Something isn't working server affecting natlas-server

Comments

@sdupreez
Copy link

Affecting:
Server

Version:
0.6.7

Describe the bug
When attempting to tag an IP that is part of the Black List, nothing happens. The tag modal never appears and you are unable to tag black list entries.

To Reproduce
Steps to reproduce the behavior:
1.Go to /admin
2.Choose the Blacklist tab
3.Add entries into Blacklist
4.Click 3 vertical dots next to a Blacklist item
5.From the pop-up menu, choose Tag

Expected behavior
One would expect a modal to pop-up, that would allow you to tag an entry in the Blacklist, making use of pre-configured / added tags.

Screenshots
As nothing happens when clicking the button, no screenshot is available.

@sdupreez sdupreez added the bug Something isn't working label Oct 24, 2019
@0xdade 0xdade added the server affecting natlas-server label Oct 24, 2019
@0xdade
Copy link
Member

0xdade commented Oct 25, 2019

First, thanks for opening this issue! Welcome to the natlas community.

Good find, I'm not sure how this happened. Generally speaking there shouldn't be much use case for tagging blacklist items after they are already added to the blacklist, since blacklist items shouldn't ever show up in scan results. But I would agree that this is unexpected behavior. I committed a potential fix for this on my fork but I'm not in a place where I can currently test/confirm it for the next few days, so it won't make it upstream until early next week at the earliest.

@0xdade 0xdade closed this as completed in 105ed2d Nov 2, 2019
0xdade added a commit that referenced this issue Nov 2, 2019
Fixes blacklist tagging and overall improves flaws in the tagging system. Closes #206.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working server affecting natlas-server
Projects
None yet
Development

No branches or pull requests

2 participants