Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Docker-only #281

Merged
merged 6 commits into from
Jun 16, 2020
Merged

Move to Docker-only #281

merged 6 commits into from
Jun 16, 2020

Conversation

0xdade
Copy link
Member

@0xdade 0xdade commented Jun 15, 2020

Maintaining the bare OS setup-*.sh scripts was a real pain. It required testing on specific OS versions and then making sure that we were installing the right versions of packages from the package managers of that OS (of which we only ever really supported ubuntu 18.04).

By moving to only support docker deployments, we can save a lot of overhead by creating consistently reproducible deployments. We can update the docker files centrally and all a user has to do is pull the new image, instead of pulling the new version and rerunning the setup scripts.

Documentation has been updated to remove instructions for non-dockerized installations.

@0xdade 0xdade requested a review from ajacques June 15, 2020 01:11
@codeclimate
Copy link

codeclimate bot commented Jun 15, 2020

Code Climate has analyzed commit d35f737 and detected 0 issues on this pull request.

View more on Code Climate.

@0xdade 0xdade linked an issue Jun 15, 2020 that may be closed by this pull request
docker-compose.yml Outdated Show resolved Hide resolved
@0xdade 0xdade added agent affecting natlas-agent server affecting natlas-server labels Jun 15, 2020
@0xdade 0xdade merged commit dc33e6e into natlas:main Jun 16, 2020
@0xdade 0xdade deleted the docker_only branch June 16, 2020 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent affecting natlas-agent server affecting natlas-server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatible Node version
2 participants