Fix: Significant performance improvements to ScopeManager #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xdade
added
server
|
Code Climate has analyzed commit b8f5b55 and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
ajacques
approved these changes
Jul 23, 2020
0xdade
force-pushed
the
scope_manager_improvements
branch
from
d94fbeb
to
d627250
Compare
Through a custom request, it was discovered that ScopeManager had a huge overhead when initializing on large sets of CIDR ranges. E.g. when you load several thousand single ip addresses in as individual scopeitems. In the test data that I used, these changes took initialization time from 50+ minutes down to only 500ms. Additional tests written for the scope manager, file names updated to match style.
0xdade
force-pushed
the
scope_manager_improvements
branch
from
d627250
to
b8f5b55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Through a custom request, it was discovered that ScopeManager had a huge overhead when initializing on large sets of CIDR ranges. E.g. when you load several thousand single ip addresses in as individual scopeitems. In the test data that I used, these changes took initialization time from 50+ minutes down to only 500ms.
Additional tests written for the scope manager, file names updated to match style.