Fix: xvfb-run negates the need to check for DISPLAY. #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y never worked in docker.
0xdade
changed the title
|
Code Climate has analyzed commit df68095 and detected 0 issues on this pull request. View more on Code Climate. |
ajacques
approved these changes
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: xvfb-run negates the need to check for DISPLAY. This has probably never worked in docker.
This is a bug fix only, the pending plugin architecture will make the vnc logic much more robust to check for other ports as well, since we'll have structured access to the data.
Thanks to @fdcarl for pointing this out as the problem.