Change: Default MAIL_USE_TLS to True (secure by default), update docs #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This closes #407 by updating documentation around the MAIL_USE_TLS and MAIL_USE_SSL options. Additionally, setting the default MAIL_USE_TLS to True makes sense since MAIL_PORT defaults to 587 now.
0xdade
added
server
|
Code Climate has analyzed commit c15323d and detected 0 issues on this pull request. View more on Code Climate. |
ajacques
approved these changes
Aug 5, 2020
ajacques
reviewed
Aug 5, 2020
| @@ -66,7 +66,8 @@ class Config(object): | |||
| # MAIL SETTINGS | |||
| MAIL_SERVER = os.environ.get("MAIL_SERVER", None) | |||
| MAIL_PORT = int(os.environ.get("MAIL_PORT", 587)) | |||
| MAIL_USE_TLS = casted_bool(os.environ.get("MAIL_USE_TLS", False)) | |||
| MAIL_USE_TLS = casted_bool(os.environ.get("MAIL_USE_TLS", True)) | |||
| MAIL_USE_SSl = casted_bool(os.environ.get("MAIL_USE_SSL", False)) | |||
There was a problem hiding this comment.
I don't know what you're talking about
natlas/natlas-server/config.py
Line 70 in 943b660
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #407 by updating documentation around the MAIL_USE_TLS and MAIL_USE_SSL options. Additionally, setting the default MAIL_USE_TLS to True makes sense since MAIL_PORT defaults to 587 now.