Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for Accounts reload #784

Merged
merged 2 commits into from Oct 24, 2018
Merged

Added support for Accounts reload #784

merged 2 commits into from Oct 24, 2018

Conversation

kozlovic
Copy link
Member

Signed-off-by: Ivan Kozlovic ivan@synadia.com

@kozlovic
Added support for Accounts reload
d35bb56 
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
@coveralls
Copy link

coveralls commented Oct 23, 2018 •
edited

Coverage Status

Coverage increased (+0.1%) to 92.598% when pulling 9a1cb08 on accounts_reload into 77548d4 on master.

derekcollison
derekcollison reviewed Oct 24, 2018
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments. This will be a fun rebase merge with new_routes ;)

server/auth.go Outdated Show resolved Hide resolved
server/auth.go Outdated Show resolved Hide resolved
server/client.go Show resolved Hide resolved
server/auth.go Outdated Show resolved Hide resolved
server/client.go Outdated Show resolved Hide resolved
server/reload.go Show resolved Hide resolved
server/reload.go Outdated Show resolved Hide resolved
server/reload.go Outdated Show resolved Hide resolved
@kozlovic
Updates based on comments
9a1cb08 
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
derekcollison
derekcollison approved these changes Oct 24, 2018
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozlovic kozlovic merged commit d33be3a into master Oct 24, 2018
@kozlovic kozlovic deleted the accounts_reload branch October 24, 2018 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kozlovic @coveralls @derekcollison